From cd299169e0e20aee5bb3d3ed1eb74aa8a03f8cc4 Mon Sep 17 00:00:00 2001
From: Emmanuel Viennet <emmanuel.viennet@gmail.com>
Date: Tue, 15 Mar 2022 23:09:41 +0100
Subject: [PATCH] Fixes #339

---
 app/scodoc/sco_edit_ue.py                   | 15 +++++++++------
 app/scodoc/sco_formations.py                | 14 +++++++++-----
 app/static/js/table_editor.js               |  8 +++++---
 app/templates/pn/form_modules_ue_coefs.html |  6 +++++-
 app/views/pn_modules.py                     |  3 ++-
 5 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/app/scodoc/sco_edit_ue.py b/app/scodoc/sco_edit_ue.py
index 98d05e9ab..a91a8b144 100644
--- a/app/scodoc/sco_edit_ue.py
+++ b/app/scodoc/sco_edit_ue.py
@@ -724,13 +724,16 @@ du programme" (menu "Semestre") si vous avez un semestre en cours);
             {formation.referentiel_competence.type_titre} {formation.referentiel_competence.specialite_long}
             </a>&nbsp;"""
             msg_refcomp = "changer"
-        H.append(
-            f"""
-        <ul>
-        <li>{descr_refcomp} <a class="stdlink" href="{url_for('notes.refcomp_assoc_formation', 
+        H.append(f"""<ul><li>{descr_refcomp}""")
+        if current_user.has_permission(Permission.ScoChangeFormation):
+            H.append(
+                f"""<a class="stdlink" href="{url_for('notes.refcomp_assoc_formation', 
         scodoc_dept=g.scodoc_dept, formation_id=formation_id)
-        }">{msg_refcomp}</a>
-        </li>
+        }">{msg_refcomp}</a>"""
+            )
+
+        H.append(
+            f"""</li>
         <li> <a class="stdlink" href="{
             url_for('notes.edit_modules_ue_coefs', scodoc_dept=g.scodoc_dept, formation_id=formation_id, semestre_idx=semestre_idx)
         }">éditer les coefficients des ressources et SAÉs</a>
diff --git a/app/scodoc/sco_formations.py b/app/scodoc/sco_formations.py
index 573c95dfb..8b99a0678 100644
--- a/app/scodoc/sco_formations.py
+++ b/app/scodoc/sco_formations.py
@@ -328,11 +328,15 @@ def formation_list_table(formation_id=None, args={}):
                 "session_id)s<a> " % s
                 for s in f["sems"]
             ]
-            + [
-                '<a class="stdlink" id="add-semestre-%s" '
-                'href="formsemestre_createwithmodules?formation_id=%s&semestre_id=1">ajouter</a> '
-                % (f["acronyme"].lower().replace(" ", "-"), f["formation_id"])
-            ]
+            + (
+                [
+                    '<a class="stdlink" id="add-semestre-%s" '
+                    'href="formsemestre_createwithmodules?formation_id=%s&semestre_id=1">ajouter</a> '
+                    % (f["acronyme"].lower().replace(" ", "-"), f["formation_id"])
+                ]
+                if current_user.has_permission(Permission.ScoImplement)
+                else []
+            )
         )
         if f["sems"]:
             f["date_fin_dernier_sem"] = max([s["date_fin_iso"] for s in f["sems"]])
diff --git a/app/static/js/table_editor.js b/app/static/js/table_editor.js
index 837c404b8..ae2489630 100644
--- a/app/static/js/table_editor.js
+++ b/app/static/js/table_editor.js
@@ -36,10 +36,12 @@ function build_table(data) {
 /*****************************/
 /* Gestion des évènements    */
 /*****************************/
-$(function () {
-    document.body.addEventListener("keydown", key);
-});
+
 function installListeners() {
+    if (read_only) {
+        return;
+    }
+    document.body.addEventListener("keydown", key);
     document.querySelectorAll("[data-editable=true]").forEach(cellule => {
         cellule.addEventListener("click", function () { selectCell(this) });
         cellule.addEventListener("dblclick", function () { modifCell(this) });
diff --git a/app/templates/pn/form_modules_ue_coefs.html b/app/templates/pn/form_modules_ue_coefs.html
index 186a8e7fd..f022eccd3 100644
--- a/app/templates/pn/form_modules_ue_coefs.html
+++ b/app/templates/pn/form_modules_ue_coefs.html
@@ -1,8 +1,11 @@
 {# -*- mode: jinja-html -*- #}
-<h2>Édition des coefficients des modules vers les UEs</h2>
+<h2>{% if not read_only %}Édition des c{% else %}C{%endif%}oefficients des modules vers les UEs</h2>
 <div class="help">
+{% if not read_only %}
     Double-cliquer pour changer une valeur.
     Les valeurs sont automatiquement enregistrées au fur et à mesure.
+{% endif %}
+
 </div>
 <form class="semestre_selector">Semestre:
     <select onchange="this.form.submit()"" name="semestre_idx" id="semestre_idx">
@@ -21,6 +24,7 @@
 <div class="tableau"></div>
 
 <script>
+    var read_only={{"true" if read_only else "false"}};
     $(function () {
         let data_url = "{{data_source}}";
         $.getJSON(data_url, function (data) {
diff --git a/app/views/pn_modules.py b/app/views/pn_modules.py
index 935020e62..313d3d0dc 100644
--- a/app/views/pn_modules.py
+++ b/app/views/pn_modules.py
@@ -151,7 +151,7 @@ def set_module_ue_coef():
 
 @bp.route("/edit_modules_ue_coefs")
 @scodoc
-@permission_required(Permission.ScoChangeFormation)
+@permission_required(Permission.ScoView)
 def edit_modules_ue_coefs():
     """Formulaire édition grille coefs EU/modules"""
     formation_id = int(request.args["formation_id"])
@@ -194,6 +194,7 @@ def edit_modules_ue_coefs():
                 "notes.set_module_ue_coef",
                 scodoc_dept=g.scodoc_dept,
             ),
+            read_only=not current_user.has_permission(Permission.ScoChangeFormation),
             semestre_idx=semestre_idx,
             semestre_ids=range(1, formation.get_parcours().NB_SEM + 1),
         ),