From 1b037d6c7c75eca60d210a7897d9953840b8d84a Mon Sep 17 00:00:00 2001
From: Iziram <matthias.hartmann@iziram.fr>
Date: Fri, 1 Mar 2024 16:04:16 +0100
Subject: [PATCH 1/2] =?UTF-8?q?Assiduit=C3=A9=20:=20fix=20format=20nbabs?=
 =?UTF-8?q?=20sidebar?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/scodoc/html_sidebar.py | 2 +-
 app/templates/sidebar.j2   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/scodoc/html_sidebar.py b/app/scodoc/html_sidebar.py
index 2d351e628..008d366b9 100755
--- a/app/scodoc/html_sidebar.py
+++ b/app/scodoc/html_sidebar.py
@@ -185,7 +185,7 @@ def sidebar(etudid: int = None):
                     formsemestre.date_fin.strftime("%d/%m/%Y")
                 }">({
                     sco_preferences.get_preference("assi_metrique", None)})
-                <br>{nbabsjust:1.0f} J., {nbabsnj:1.0f} N.J.</span>"""
+                <br>{nbabsjust:1g} J., {nbabsnj:1g} N.J.</span>"""
             )
         H.append("<ul>")
         if current_user.has_permission(Permission.AbsChange):
diff --git a/app/templates/sidebar.j2 b/app/templates/sidebar.j2
index 00c612301..5e8f349f0 100755
--- a/app/templates/sidebar.j2
+++ b/app/templates/sidebar.j2
@@ -58,7 +58,7 @@
         {% if sco.etud_cur_sem %}
         <span title="absences du {{ sco.etud_cur_sem['date_debut'].strftime('%d/%m/%Y') }}
         au {{ sco.etud_cur_sem['date_fin'].strftime('%d/%m/%Y') }}">({{sco.prefs["assi_metrique"]}})
-            <br />{{'%1.0f'|format(sco.nbabsjust)}} J., {{'%1.0f'|format(sco.nbabsnj)}} N.J.</span>
+            <br />{{'%1g'|format(sco.nbabsjust)}} J., {{'%1g'|format(sco.nbabsnj)}} N.J.</span>
         {% endif %}
         <ul>
             {% if current_user.has_permission(sco.Permission.AbsChange) %}
@@ -94,4 +94,4 @@
             {{ scu.icontag("scologo_img", no_size=True) | safe}}</a>
     </div>
 </div>
-<!-- end of sidebar -->
+<!-- end of sidebar -->
\ No newline at end of file

From 71f90f5261bc5af0463e37696562f8eb919d711c Mon Sep 17 00:00:00 2001
From: Iziram <matthias.hartmann@iziram.fr>
Date: Fri, 1 Mar 2024 16:35:39 +0100
Subject: [PATCH 2/2] =?UTF-8?q?Assiduit=C3=A9=20:=20annulation=20/=20suppr?=
 =?UTF-8?q?ession=20fichier=20justif?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../pages/ajout_justificatif_etud.j2          | 47 +++++--------------
 app/views/assiduites.py                       | 11 ++++-
 2 files changed, 21 insertions(+), 37 deletions(-)

diff --git a/app/templates/assiduites/pages/ajout_justificatif_etud.j2 b/app/templates/assiduites/pages/ajout_justificatif_etud.j2
index feced80e8..d1cdd200c 100644
--- a/app/templates/assiduites/pages/ajout_justificatif_etud.j2
+++ b/app/templates/assiduites/pages/ajout_justificatif_etud.j2
@@ -154,50 +154,25 @@ div.submit > input {
 {% include "sco_timepicker.j2" %}
 <script>
 document.addEventListener("DOMContentLoaded", function() {
-    // Suppression d'un fichier justificatif
-    function delete_file(justif_id, fileName, liElement) {
-        // Construct the URL
-        var url = "{{url_for('apiweb.justif_remove', justif_id=-1, scodoc_dept=g.scodoc_dept)}}".replace('-1', justif_id);
-
-        payload = {
-            "remove": "list",
-            "filenames" : [ fileName ],
-        }
-        // Send API request
-        fetch(url, {
-            method: 'POST',
-            headers: {
-					'Accept': 'application/json',
-					'Content-Type': 'application/json'
-			},
-			body: JSON.stringify(payload)
-        })
-        .then(response => {
-            if (response.ok) {
-                // Hide the <li> element on successful deletion
-                liElement.style.display = 'none';
-                sco_message("fichier supprimé");
-            } else {
-                // Handle non-successful responses here
-                console.error('Deletion failed:', response.statusText);
-                sco_error_message("erreur lors de la suppression du fichier");
-            }
-        })
-        .catch(error => {
-            console.error('Error:', error);
-            sco_error_message("erreur lors de la suppression du fichier (2)");
-        });
-    }
-
     // Add event listeners to all elements with class 'suppr_fichier_just'
     var deleteButtons = document.querySelectorAll('.suppr_fichier_just');
+    const form = document.getElementById('ajout-justificatif-etud');
     deleteButtons.forEach(function(button) {
         button.addEventListener('click', function() {
             // Get the text content of the next sibling node
             var justif_id = this.dataset.justif_id;
             var fileName = this.nextSibling.nodeValue.trim();
             var liElement = this.parentNode;  // Get the parent <li> element
-            delete_file(justif_id, fileName, liElement);
+
+            // Create a hidden input element to store the file name
+            var input = document.createElement('input');
+            input.type = 'hidden';
+            input.name = 'suppr_fichier_just';
+            input.value = fileName;
+            form.appendChild(input);
+
+            liElement.remove();
+
         });
     });
 });
diff --git a/app/views/assiduites.py b/app/views/assiduites.py
index 6b2e931a2..4d89939f4 100644
--- a/app/views/assiduites.py
+++ b/app/views/assiduites.py
@@ -658,6 +658,8 @@ def edit_justificatif_etud(justif_id: int):
         etudid=justif.etudiant.id,
     )
     if form.validate_on_submit():
+        if form.cancel.data:  # cancel button
+            return redirect(redirect_url)
         if _record_justificatif_etud(justif.etudiant, form, justif):
             return redirect(redirect_url)
 
@@ -757,7 +759,6 @@ def _record_justificatif_etud(
         dt_fin_tz_server,
         dt_entry_date_tz_server,
     ) = _get_dates_from_assi_form(form, all_day=True)
-
     if not ok:
         log("_record_justificatif_etud: dates invalides")
         form.set_error("Erreur: dates invalides")
@@ -793,6 +794,14 @@ def _record_justificatif_etud(
                 )
             else:
                 message = "Pas de modification"
+            fichier_suppr: list[str] = request.form.getlist("suppr_fichier_just")
+
+            if len(fichier_suppr) > 0 and justif.fichier is not None:
+                archiver: JustificatifArchiver = JustificatifArchiver()
+                for fichier in fichier_suppr:
+                    archiver.delete_justificatif(etud, justif.fichier, fichier)
+                    flash(f"Fichier {fichier} supprimé")
+
         else:
             justif = Justificatif.create_justificatif(
                 etud,