From 6f0b03242df444474837218144d0a19f4ed3b39e Mon Sep 17 00:00:00 2001
From: Emmanuel Viennet <emmanuel.viennet@gmail.com>
Date: Tue, 11 Jan 2022 22:44:03 +0100
Subject: [PATCH] modif exc. handling

---
 app/scodoc/html_sidebar.py          | 3 ++-
 app/scodoc/sco_groups.py            | 4 +++-
 app/scodoc/sco_moduleimpl_status.py | 3 +++
 sco_version.py                      | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/app/scodoc/html_sidebar.py b/app/scodoc/html_sidebar.py
index b3bf18a36..53efbfc95 100644
--- a/app/scodoc/html_sidebar.py
+++ b/app/scodoc/html_sidebar.py
@@ -35,13 +35,14 @@ from flask_login import current_user
 import app.scodoc.sco_utils as scu
 from app.scodoc import sco_preferences
 from app.scodoc.sco_permissions import Permission
+from sco_version import SCOVERSION
 
 
 def sidebar_common():
     "partie commune à toutes les sidebar"
     home_link = url_for("scodoc.index", scodoc_dept=g.scodoc_dept)
     H = [
-        f"""<a class="scodoc_title" href="{home_link}">ScoDoc 9.1</a><br>
+        f"""<a class="scodoc_title" href="{home_link}">ScoDoc {SCOVERSION}</a><br>
         <a href="{home_link}" class="sidebar">Accueil</a> <br>
         <div id="authuser"><a id="authuserlink" href="{
             url_for("users.user_info_page", 
diff --git a/app/scodoc/sco_groups.py b/app/scodoc/sco_groups.py
index 0ecc1a2af..8248491af 100644
--- a/app/scodoc/sco_groups.py
+++ b/app/scodoc/sco_groups.py
@@ -284,7 +284,9 @@ def get_group_infos(group_id, etat=None):  # was _getlisteetud
 
     cnx = ndb.GetDBConnexion()
     group = get_group(group_id)
-    sem = sco_formsemestre.get_formsemestre(group["formsemestre_id"])
+    sem = sco_formsemestre.get_formsemestre(
+        group["formsemestre_id"], raise_soft_exc=True
+    )
 
     members = get_group_members(group_id, etat=etat)
     # add human readable description of state:
diff --git a/app/scodoc/sco_moduleimpl_status.py b/app/scodoc/sco_moduleimpl_status.py
index 33f51da14..27de3a699 100644
--- a/app/scodoc/sco_moduleimpl_status.py
+++ b/app/scodoc/sco_moduleimpl_status.py
@@ -36,6 +36,7 @@ from app.auth.models import User
 from app.models import ModuleImpl
 from app.models.evaluations import Evaluation
 import app.scodoc.sco_utils as scu
+from app.scodoc.sco_exceptions import ScoInvalidIdType
 from app.scodoc.sco_permissions import Permission
 
 from app.scodoc import html_sco_header
@@ -183,6 +184,8 @@ def _ue_coefs_html(coefs_descr) -> str:
 
 def moduleimpl_status(moduleimpl_id=None, partition_id=None):
     """Tableau de bord module (liste des evaluations etc)"""
+    if not isinstance(moduleimpl_id, int):
+        raise ScoInvalidIdType("moduleimpl_id must be an integer !")
     modimpl = ModuleImpl.query.get_or_404(moduleimpl_id)
     M = modimpl.to_dict()
     formsemestre_id = M["formsemestre_id"]
diff --git a/sco_version.py b/sco_version.py
index 1893a44fd..64e77bf1b 100644
--- a/sco_version.py
+++ b/sco_version.py
@@ -1,7 +1,7 @@
 # -*- mode: python -*-
 # -*- coding: utf-8 -*-
 
-SCOVERSION = "9.1.23"
+SCOVERSION = "9.1.24"
 
 SCONAME = "ScoDoc"